Update test images for ARM and OCP 3.11 #1652
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hash-d
added
do-not-merge
hash-d
force-pushed
the
dh-arm-test-images
branch
from
02d56f7 to
89bd569
Compare
https://hub.docker.com/r/curlimages/curl points to the quay presence
Some images need to be 'reassembled' instead of simply copied
- Better naming: what was before 'external', was changed to 'replicated'. That is, images that are copied from elsewhere into the MAIN_REPO - Tasks now print what they're doing. Helps on debugging and to generally understand what's going on - New lists of images added: external and other, for use with the copy operation. External images are accessed from the tests directly on their original (non-dockerhub) locations. Others are created by the project, but not using this makefile. - Moved images between lists, as necessary, after testing - General documentation improvements
quay.io/nginx images are not compatible with OCP 3.11
And Conditions[0] might have been SuccessCriteriaMet for a successful execution, which failed the test and reported nothing.
otherwise they'd not be shown in case of failure
hash-d
force-pushed
the
dh-arm-test-images
branch
from
eb7d404 to
e7f95e3
Compare
hash-d
changed the title
hash-d
requested review from
nluaces and
fgiorgetti
and removed request for
nluaces
hash-d
added a commit
to hash-d/skupper
that referenced
this pull request
Dec 3, 2024
* Update test images on quay.io/skupper that do not have ARM support * Copy additional images from DockerHub into Quay.io * Ensure all such images are compatible with OCP 3.11 as well * Mark whichever tests cannot be run on ARM, due to unavailability of supporting test images
Merged
hash-d
added a commit
that referenced
this pull request
Dec 17, 2024
* Update test images on quay.io/skupper that do not have ARM support * Copy additional images from DockerHub into Quay.io * Ensure all such images are compatible with OCP 3.11 as well * Mark whichever tests cannot be run on ARM, due to unavailability of supporting test images
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
On this PR:
This PR depends on other PRs on different repositories: